Explicitly specified string must stay a string #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrelmiller, please take a look. |
VitaliyKurokhtin
force-pushed
the
vvk/explicit-string
branch
from
27a2e96 to
2c7663a
Compare
|
Hey @VitaliyKurokhtin Thanks for the PR. Sorry it took so long for me to get around to looking at this. I am a bit concerned that we will lose the ability to represent DateTime values natively with this change. There's no choice but to explicitly quote them in when using JSON style and therefore DateTimes are always going to come back as strings. This isn't necessarily a terrible thing, but it would definitely be a breaking change. |
|
Good point. I'll make a change to bring back older behavior for DateTimes specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If string value was specified in YAML explicitly via quotes, or one of the other string syntaxes it must not be converted into any other type.